Remove unneeded tests for StoreKit2 with JWS #3747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkVillacampa
approved these changes
Mar 5, 2024
MarkVillacampa
approved these changes
Mar 5, 2024
joshdholtz
changed the title
joshdholtz
pushed a commit
that referenced
this pull request
Mar 6, 2024
**This is an automatic release.** ### Bugfixes * Fix for passing `TargetingContext` when using `currentOffering(forPlacement:)` (#3751) via Josh Holtz (@joshdholtz) ### Other Changes * Remove unneeded tests for StoreKit2 with JWS (#3747) via Josh Holtz (@joshdholtz)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Unlock shipping by skipping tests that are flaky unneeded tests
Description
Removing StoreKit2JWS tests from
BackendIntegrationTests-SK2.xctestplanStoreKit2JWSIntegrationTests(which is theusesStoreKit2JWSdangerous setting), is not publicly available in iOS v4. Its intention was intended only for iOS v5. These tests are safe to skip since they have no production use.