Improve promotional offer button when pressed #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
approved these changes
Oct 3, 2024
| withAnimation(.easeInOut(duration: 0.3)) { | ||
| loadingState = true | ||
| } | ||
| await viewModel.purchasePromo() |
There was a problem hiding this comment.
Just to make sure but this shouldn't trigger any errors right?
There was a problem hiding this comment.
we are catching the error, and not doing anything with it atm, but that's from before this change, so that improvement should come in a different PR
JayShortway
approved these changes
Oct 4, 2024
| @@ -35,6 +35,7 @@ struct PromotionalOfferView: View { | |||
| private var appearance: CustomerCenterConfigData.Appearance | |||
| @Environment(\.colorScheme) | |||
| private var colorScheme | |||
| @State private var loadingState: Bool = false | |||
There was a problem hiding this comment.
Super nit suggestion for your consideration:
- @State private var loadingState: Bool = false
+ @State private var isLoading: Bool = false
vegaro
deleted the
sdk-3596-promotional-offer-view-button-is-touchable-multiple-times
branch
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #4335
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-10-02.at.16.44.56.mp4