CAT-1726: Support Deferring Win-Back StoreKit Messages #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-at-will
changed the title
fire-at-will
commented
Oct 2, 2024
| @@ -40,6 +47,14 @@ extension Message.Reason { | |||
| case .priceIncreaseConsent: return .priceIncreaseConsent | |||
| case .generic: return .generic | |||
| default: | |||
| // winBackOffer message reason was added in iOS 18.0, but it's not recognized by xcode versions <16.0. | |||
| // https://developer.apple.com/documentation/xcode-release-notes/xcode-14_3-release-notes | |||
| #if swift(>=6.0) | |||
There was a problem hiding this comment.
See the PR description for more details on why this is necessary
There was a problem hiding this comment.
the swift compilation condition defines the swift mode, whereas compiler refers to the swift compiler version.
A lot of people will compile in Swift 5.X mode while using Xcode. Since what we actually want to do is detect the Xcode version, and Xcode 16 comes with the Swift 6.0 compiler, it's better to use the compiler condition instead of swift, as we know if ties directly the Xcode version.
There was a problem hiding this comment.
Woah, TIL! Will switch to using the compiler condition. Thank you!!
There was a problem hiding this comment.
Switched in to using the compiler condition in 086dce6 😎
fire-at-will
changed the title
MarkVillacampa
approved these changes
Oct 4, 2024
fire-at-will
deleted the
CAT-1726_support_deferring_winback_sk_messages
branch
This was referenced Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
iOS 18 introduces win-back offers to allow developers to extend offers to churned subscribers. In iOS 18+, StoreKit sends apps a StoreKit Message when a subscriber is eligible to redeem a win-back offer. We currently support showing this message automatically if the
showStoreMessagesAutomaticallyconfiguration option istrue, but don't yet support deferring displaying the message.Description
This PR adds win-back offers to the
StoreMessageTypeenum so that we can support deferring StoreKit Messages where the reason iswinBackOffer.Xcode Compatibility Issues
StoreKit.Message.Reason.winBackOfferis available on iOS 18.0+ and wasn't back ported to be available in Xcode versions <16.0. Thus, if we referenceStoreKit.Message.Reason.winBackOfferwithout checking for the Xcode version, we'll break compilation on all versions of Xcode less than 16.0:Since Swift doesn't provide a way to do conditional compilation based on Xcode version, our next best option is to check the Swift compiler version, since the Swift compiler version is tied to Xcode versions. Since the Swift 6 compiler shipped with Xcode 16, this PR makes our handling of deferred win-back offer messages dependent on the Swift compiler version being >=6.0.
Testing