Better spacing in PromotionalOfferView
#4369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayShortway
approved these changes
Oct 11, 2024
Comment on lines
105
to
109
| private enum Constants { | ||
| static let spacing: CGFloat = 30 | ||
| static let topPadding: CGFloat = 150 | ||
| static let horizontalPadding: CGFloat = 40 | ||
| } |
There was a problem hiding this comment.
Not a blocker at all, but I'd be fine with these being directly in the PromotionalOfferHeaderView, outside of the enum. (Unless there's a reason to keep them in the enum of course.)
(This applies to the other Constants enum in the PromotionalOfferView too.)
JayShortway
approved these changes
Oct 11, 2024
This was referenced Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported at #4355