[Paywalls V2] Update Image to handle property overrides #4477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
force-pushed
the
paywalls-v2/schema-rework-part-7-image-selection-state
branch
from
aaa66ec
to
1fe4900
Compare
vegaro
reviewed
Nov 13, 2024
| condition: ScreenCondition, | ||
| apply: @escaping (ImageComponentStyle) -> some View | ||
| ) -> some View { | ||
| let localalizedPartial = LocalizedImagePartial.buildPartial( |
There was a problem hiding this comment.
Suggested change
| let localalizedPartial = LocalizedImagePartial.buildPartial( | |
| let localizedPartial = LocalizedImagePartial.buildPartial( |
vegaro
approved these changes
Nov 13, 2024
joshdholtz
force-pushed
the
paywalls-v2/schema-rework-part-6-stack-selection-state
branch
from
9fc70a4
to
05ca788
Compare
Base automatically changed from
paywalls-v2/schema-rework-part-6-stack-selection-state
to
main
November 13, 2024 14:00
joshdholtz
force-pushed
the
paywalls-v2/schema-rework-part-7-image-selection-state
branch
from
1fe4900
to
a398690
Compare
joshdholtz
deleted the
paywalls-v2/schema-rework-part-7-image-selection-state
branch
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds size class, selection state, and intro offer overrides to image
Description
See #4476 for more info