Fix: sharedPurchases nullability #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
commented
May 21, 2021
| @note True if the SDK has been configured, false otherwise. This property should only be used in special circumstances. If the shared instance has not been configured, | ||
| calls made to it will raise an exception. | ||
| */ | ||
| @property (class, nonatomic, readonly) BOOL isConfigured; |
There was a problem hiding this comment.
This doesn't exist in Android, and I'm not 100% sure it's needed.
However, we are changing the behavior of the SDK, so maybe it's helpful for some folks if they're migrating behaviors.
Note that the previous behavior is the no-op, which no one should really have been relying on.
vegaro
approved these changes
May 24, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #490, the value of
sharedPurchasescan benil, but it's marked asnon-nullable.This can lead to some awkward behavior, particularly in Swift, where the compiler will assume that the value is not
niland will not let you check against it.To solve this, this PR does 2 things:
assertwhen callingsharedPurchases, since calls to it will no-op, which is unexpected behavior the vast majority of the time.isConfigured, that you can use to know whether it's safe to callsharedPurchases. I added this so that if someone is indiscriminately calling a method and relying on no-ops, they can use the new property to keep their code compatible with this behavior. However, this should only ever be used in very specific circumstances.