remove remaining fatalErrors
#529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
whooa, a linter! cool! I'll update |
aboedo
force-pushed
the
fix/remove_remaining_fatalErrors
branch
from
c2e95f1
to
7802cfe
Compare
taquitos
reviewed
Jun 15, 2021
| @@ -5,10 +5,14 @@ | |||
|
|
|||
| import Foundation | |||
|
|
|||
| enum DateExtensionsError: Error { | |||
| case notValidDateFromComponents | |||
There was a problem hiding this comment.
nit: I think invalidDateComponents could be a better name
There was a problem hiding this comment.
I'm sorry I didn't catch this before, I just realized it might be useful to capture the date components that trigger this and spit those out to aid folks in debugging. Thoughts?
taquitos
approved these changes
Jun 16, 2021
…nvalidDateComponents error
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #394
Replaces the last few remaining
fatalErrors with better error handling.