Add canMakePayments #52
Conversation
beylmk
changed the title
| @@ -18,7 +18,8 @@ public partial class Purchases : MonoBehaviour | |||
| public delegate void GetOfferingsFunc(Offerings offerings, Error error); | |||
|
|
|||
| public delegate void CheckTrialOrIntroductoryPriceEligibilityFunc(Dictionary<string, IntroEligibility> products); | |||
|
|
|||
|
|
|||
| public delegate void CanMakePaymentsFunc(bool canMakePayments, Error error); | |||
There was a problem hiding this comment.
I know we don't have docs for the other functions, but I think we should start adding them (and add for all the other functions on a Friday). Do you mind adding docs here?
There was a problem hiding this comment.
@vegaro created clubhouse ticket for the others: https://app.clubhouse.io/revenuecat/story/7152/add-documentation-to-unity-functions, as well as a ticket for researching/setting up unit testing (if you could add comments on that tool you saw, that'd be great...): https://app.clubhouse.io/revenuecat/story/7153/research-set-up-unity-unit-tests
| @@ -17,8 +17,7 @@ private class ProductsRequest | |||
| { | |||
| public string[] productIdentifiers; | |||
| } | |||
|
|
|||
| [DllImport("__Internal")] | |||
| [DllImport("__Internal")] | |||
There was a problem hiding this comment.
I think this change is unintended
| @@ -29,6 +28,7 @@ public void GetProducts(string[] productIdentifiers, string type = "subs") | |||
|
|
|||
| _RCGetProducts(JsonUtility.ToJson(request), type); | |||
| } | |||
|
|
|||
beylmk
force-pushed
the
can-make-payments
branch
from
c53483f
to
a70d2f0
Compare
|
|
||
| void _RCCanMakePayments(const char *featuresJSON) { | ||
| NSError *error = nil; | ||
| NSDictionary *canMakePaymentsRequest = [NSJSONSerialization JSONObjectWithData:[convertCString(featuresJSON) dataUsingEncoding:NSUTF8StringEncoding] options:0 error:&error]; |
There was a problem hiding this comment.
let's add a line break here for readability, either by extracting the CString conversion into its own line or by doing a line per parameter
| @@ -0,0 +1,72 @@ | |||
| // GENERATED BY UNITY. REMOVE THIS COMMENT TO PREVENT OVERWRITING WHEN EXPORTING AGAIN | |||
There was a problem hiding this comment.
was checking in this file intended?
beylmk
force-pushed
the
can-make-payments
branch
from
4107c58
to
9ee25b9
Compare
| try { | ||
| object.put("canMakePayments", canMakePayments); | ||
| } catch (JSONException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
why the difference in error handling between here and line 324354?
There was a problem hiding this comment.
ah, no real reasoning just copy pasta. i'll update so they're consistent 👍
| JSONObjectWithData:[convertCString(featuresJSON) | ||
| dataUsingEncoding:NSUTF8StringEncoding] | ||
| options:0 | ||
| error:&error]; |
There was a problem hiding this comment.
The formatting of these lines is a little bit off
There was a problem hiding this comment.
there seemed to be a really wide array of formattings for this kinda call... this felt the most readable to me, but open to suggestions.
There was a problem hiding this comment.
In objc, : are aligned if the parameters are in different lines. Apart from that, maybe extracting the data into a variable also helps. Something like this :
NSData *data = [convertCString(featuresJSON) dataUsingEncoding:NSUTF8StringEncoding];
NSDictionary *canMakePaymentsRequest = [NSJSONSerialization JSONObjectWithData:data
options:0
error:&error];
| /// </summary> | ||
| /// <param name="features">An array of BillingFeatures to check for support. | ||
| /// If empty, no features will be checked.</param> | ||
| /// <param name="callback">A callback receiving a bool for canMakePayments and potentially an Error</param> |
There was a problem hiding this comment.
Great, love these docs thanks!!!
Adds canMakePayments method
Opening in draft because I still need to remove the aars and clean up some formatting, but ready for review on the actual implementation.