-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(macros): 🎸 derive Declare
support builtin abilitify
#535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Adoo
changed the title
feat(macros): 🎸 add
feat(macros): 🎸 derive Feb 28, 2024
simple_declarer
that not support use pipe to in…Declare
support builtin abilitify
M-Adoo
force-pushed
the
feat/declarer-extend-builtin
branch
7 times, most recently
from
March 4, 2024 13:54
9544644
to
a5b2158
Compare
M-Adoo
force-pushed
the
feat/declarer-extend-builtin
branch
2 times, most recently
from
March 7, 2024 13:30
c6b1bed
to
8d595d3
Compare
M-Adoo
force-pushed
the
feat/declarer-extend-builtin
branch
from
March 8, 2024 10:50
8d595d3
to
542f21a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 85.12% 84.92% -0.20%
==========================================
Files 180 180
Lines 25411 26316 +905
==========================================
+ Hits 21630 22350 +720
- Misses 3781 3966 +185 ☔ View full report in Codecov by Sentry. |
M-Adoo
force-pushed
the
feat/declarer-extend-builtin
branch
from
March 9, 2024 16:07
542f21a
to
23f0631
Compare
M-Adoo
requested review from
wjian23 and
sologeek
and removed request for
wjian23
March 9, 2024 16:07
sologeek
approved these changes
Mar 11, 2024
3 tasks
wjian23
approved these changes
Mar 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this Pull Request
Declare
can now utilize built-in abilities.Checklist Before Merging
Please ensure the following are completed before merging:
rdl!
macro. Widgets deriving from Query should have access to all built-in abilities.DeclareBuilder
from acceptingPipe
for field initialization if it doesn't extend BuiltinObj ability.simple_declarer
macro for types that don't usePipe
for initialization.CHANGELOG.md
file.Breaking
section of theCHANGELOG.md
file.Additional Information
If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.