feat(core): 🎸 compile wasm #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #543 +/- ##
==========================================
- Coverage 85.27% 85.19% -0.09%
==========================================
Files 179 179
Lines 25337 25378 +41
==========================================
+ Hits 21607 21621 +14
- Misses 3730 3757 +27 ☔ View full report in Codecov by Sentry. |
wjian23
force-pushed
the
feat/wasm
branch
3 times, most recently
from
d69ac35 to
fdaa5f0
Compare
M-Adoo
reviewed
Mar 28, 2024
tests/Cargo.toml
Outdated
| @@ -18,6 +18,7 @@ paste.workspace = true | |||
| ribir = {path = "../ribir", features = ["material", "widgets"]} | |||
| ribir_dev_helper = {path = "../dev-helper"} | |||
| ribir_geom = {path = "../geom"} | |||
| ribir_core = {path = "../core"} | |||
wjian23
force-pushed
the
feat/wasm
branch
2 times, most recently
from
d3093ce to
69428ea
Compare
M-Adoo
reviewed
Apr 1, 2024
.github/workflows/ci.yml
Outdated
| @@ -59,4 +59,18 @@ jobs: | |||
| { | |||
| echo ./README.md | |||
| find "./docs" -name "*.md" | |||
| } | xargs -I {} rustdoc --test {} -L target/debug/deps/ --edition 2018 --extern ribir=target/debug/libribir.rlib | |||
| } | xargs -I {} rustdoc -Z unstable-options --test --no-run {} -L target/debug/deps/ --edition 2018 --extern ribir=target/debug/libribir.rlib | |||
There was a problem hiding this comment.
should keep not use unstable-options to test docs
M-Adoo
reviewed
Apr 1, 2024
wjian23
force-pushed
the
feat/wasm
branch
2 times, most recently
from
9825af7 to
45760c9
Compare
github-actions
bot
force-pushed
the
feat/wasm
branch
from
fd473a8 to
9fe4714
Compare
github-actions
bot
force-pushed
the
feat/wasm
branch
from
76f382e to
321df76
Compare
M-Adoo
approved these changes
Apr 4, 2024
M-Adoo
approved these changes
Apr 4, 2024
sologeek
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this Pull Request
compile wasm, relative to #542
Checklist Before Merging
Please ensure the following are completed before merging:
CHANGELOG.mdfile.Breakingsection of theCHANGELOG.mdfile.Additional Information
If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.