Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): 💡 simpler names for declare APIs #547

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Mar 16, 2024

Purpose of this Pull Request

Simplify the names of the declare-related APIs

  • Declare::declare_builder to Declare::declarer,
  • DeclareBuilder to ObjDeclarer,
  • DeclareBuilder::build_declare to ObjDeclarer::finish

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

BREAKING CHANGE: 🧨 `Declare::declare_builder` to `Declare::declarer`, `DeclareBuilder` to
`ObjDeclarer`, `DeclareBuilder::build_declare` to `ObjDeclarer::finish`
@M-Adoo M-Adoo enabled auto-merge March 16, 2024 06:55
@M-Adoo M-Adoo force-pushed the refactor/declare-rename branch from 9e5473c to 6981fe1 Compare March 16, 2024 06:55
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 69.76744% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 85.48%. Comparing base (7d88e2c) to head (6981fe1).

Files Patch % Lines
core/src/builtin_widgets/anchor.rs 0.00% 1 Missing ⚠️
core/src/builtin_widgets/cursor.rs 0.00% 1 Missing ⚠️
core/src/builtin_widgets/delay_drop.rs 0.00% 1 Missing ⚠️
core/src/builtin_widgets/fitted_box.rs 0.00% 1 Missing ⚠️
core/src/builtin_widgets/focus_node.rs 0.00% 1 Missing ⚠️
core/src/builtin_widgets/global_anchor.rs 0.00% 1 Missing ⚠️
core/src/builtin_widgets/has_focus.rs 0.00% 1 Missing ⚠️
core/src/builtin_widgets/layout_box.rs 0.00% 1 Missing ⚠️
core/src/builtin_widgets/mouse_hover.rs 0.00% 1 Missing ⚠️
core/src/builtin_widgets/opacity.rs 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   85.50%   85.48%   -0.02%     
==========================================
  Files         180      180              
  Lines       26207    26207              
==========================================
- Hits        22408    22404       -4     
- Misses       3799     3803       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@M-Adoo M-Adoo added this pull request to the merge queue Mar 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2024
@M-Adoo M-Adoo added this pull request to the merge queue Mar 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2024
@M-Adoo M-Adoo added this pull request to the merge queue Mar 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2024
@M-Adoo M-Adoo added this pull request to the merge queue Mar 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 18, 2024
@M-Adoo M-Adoo added this pull request to the merge queue Mar 18, 2024
Merged via the queue into master with commit 23be218 Mar 18, 2024
5 of 7 checks passed
@M-Adoo M-Adoo deleted the refactor/declare-rename branch March 18, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants