Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ribir): 🎸 introduced AppRunGuard #565

Merged
merged 2 commits into from
Apr 26, 2024
Merged

feat(ribir): 🎸 introduced AppRunGuard #565

merged 2 commits into from
Apr 26, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Apr 25, 2024

Purpose of this Pull Request

Simplified the startup process for a Ribir app, making it easier for users to configure the app and window.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@github-actions github-actions bot force-pushed the feat-app-run-guard branch from 79923b0 to 95c5399 Compare April 25, 2024 14:41
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Apr 25, 2024
@M-Adoo M-Adoo enabled auto-merge April 25, 2024 14:41
@M-Adoo M-Adoo force-pushed the feat-app-run-guard branch from 95c5399 to 62a9103 Compare April 25, 2024 15:36
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Apr 25, 2024
@github-actions github-actions bot force-pushed the feat-app-run-guard branch from 62a9103 to f428205 Compare April 25, 2024 15:36
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Apr 25, 2024
@M-Adoo M-Adoo force-pushed the feat-app-run-guard branch from f428205 to c40e289 Compare April 25, 2024 16:01
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Apr 25, 2024
@github-actions github-actions bot force-pushed the feat-app-run-guard branch from c40e289 to 92bc53a Compare April 25, 2024 16:01
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Apr 25, 2024
@M-Adoo M-Adoo force-pushed the feat-app-run-guard branch from 92bc53a to 3fa8075 Compare April 25, 2024 16:34
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Apr 25, 2024
@github-actions github-actions bot force-pushed the feat-app-run-guard branch from 3fa8075 to f029ea3 Compare April 25, 2024 16:35
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Apr 25, 2024
@M-Adoo M-Adoo force-pushed the feat-app-run-guard branch from f029ea3 to 77113a1 Compare April 25, 2024 16:39
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Apr 25, 2024
@github-actions github-actions bot force-pushed the feat-app-run-guard branch from 77113a1 to 03a0843 Compare April 25, 2024 16:39
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Apr 25, 2024
wjian23
wjian23 previously approved these changes Apr 26, 2024
@M-Adoo M-Adoo added this pull request to the merge queue Apr 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 26, 2024
@M-Adoo M-Adoo force-pushed the feat-app-run-guard branch from 03a0843 to 4dd9eae Compare April 26, 2024 03:45
@M-Adoo M-Adoo enabled auto-merge April 26, 2024 03:45
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Apr 26, 2024
@github-actions github-actions bot force-pushed the feat-app-run-guard branch from 4dd9eae to f0f1410 Compare April 26, 2024 03:45
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Apr 26, 2024
@M-Adoo M-Adoo added this pull request to the merge queue Apr 26, 2024
Merged via the queue into master with commit 92bfc45 Apr 26, 2024
6 checks passed
@M-Adoo M-Adoo deleted the feat-app-run-guard branch April 26, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants