Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ribir): 🐛 crash when creating a zero-sized window #582

Merged
merged 1 commit into from
May 17, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented May 16, 2024

Purpose of this Pull Request

Crashes may occur when creating a zero-sized window. This can also happen when creating a normal window, if the platform initially creates it with zero size and delays resizing.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@M-Adoo M-Adoo enabled auto-merge May 16, 2024 11:00
@github-actions github-actions bot force-pushed the fix-crash-zero-window branch from 9c5c167 to 4de09e0 Compare May 16, 2024 11:00
@M-Adoo M-Adoo requested a review from wjian23 May 16, 2024 11:00
@M-Adoo M-Adoo added the B-test Notify bot to start testing label May 16, 2024
@M-Adoo M-Adoo requested a review from sologeek May 16, 2024 11:00
@M-Adoo M-Adoo force-pushed the fix-crash-zero-window branch from 4de09e0 to 203c990 Compare May 16, 2024 12:19
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label May 16, 2024
@github-actions github-actions bot force-pushed the fix-crash-zero-window branch from 203c990 to 47578cd Compare May 16, 2024 12:19
@M-Adoo M-Adoo added the B-test Notify bot to start testing label May 16, 2024
@M-Adoo M-Adoo disabled auto-merge May 17, 2024 08:10
@M-Adoo M-Adoo merged commit ed2d20a into RibirX:master May 17, 2024
6 checks passed
@M-Adoo M-Adoo deleted the fix-crash-zero-window branch May 17, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants