Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/not depends backend msaa #584

Merged
merged 4 commits into from
May 25, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented May 21, 2024

Purpose of this Pull Request

  1. Remove the anti-aliasing configuration from the painter. The backend will now decide whether to use anti-aliasing. For the wgpu backend, anti-aliasing will be used by default and implemented in the shader, independent of the platform under wgpu.
  2. Set the panic hook for all examples to improve panic information visibility in the browser.
  3. Update all image test cases to reflect the support for anti-aliasing by default.

How to Review/Test this Pull Request

You can review the code commit by commit, and run the example to see the result in the browser.

cargo run-wasm -p counter
## Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@github-actions github-actions bot force-pushed the refactor/not-depends-backend-msaa branch from 70218d9 to 4b037ea Compare May 21, 2024 06:59
@M-Adoo M-Adoo added the B-test Notify bot to start testing label May 21, 2024
@M-Adoo M-Adoo enabled auto-merge May 21, 2024 07:02
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 22, 2024
@M-Adoo M-Adoo force-pushed the refactor/not-depends-backend-msaa branch from bf4cecc to 1906f4f Compare May 22, 2024 09:28
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 22, 2024
@M-Adoo M-Adoo force-pushed the refactor/not-depends-backend-msaa branch from 289a16b to c414ec8 Compare May 22, 2024 10:45
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 22, 2024
@M-Adoo M-Adoo force-pushed the refactor/not-depends-backend-msaa branch from c414ec8 to 082db2c Compare May 22, 2024 10:49
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 22, 2024
@M-Adoo M-Adoo force-pushed the refactor/not-depends-backend-msaa branch from 082db2c to cce8618 Compare May 22, 2024 11:10
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 22, 2024
@M-Adoo M-Adoo force-pushed the refactor/not-depends-backend-msaa branch from cce8618 to a54c453 Compare May 22, 2024 11:33
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 22, 2024
wjian23
wjian23 previously approved these changes May 24, 2024
…er` package

This responsibility now lies with the painter backend.
The GPU backend no longer relies on MSAA, which is dependent on the graphics API. Instead, it uses the alpha atlas to provide a solution similar to SSAA.
sologeek
sologeek previously approved these changes May 25, 2024
@M-Adoo M-Adoo added this pull request to the merge queue May 25, 2024
@sologeek sologeek removed this pull request from the merge queue due to a manual request May 25, 2024
@M-Adoo M-Adoo dismissed stale reviews from sologeek and wjian23 via b2f0961 May 25, 2024 09:33
@M-Adoo M-Adoo force-pushed the refactor/not-depends-backend-msaa branch from a54c453 to b2f0961 Compare May 25, 2024 09:33
@M-Adoo M-Adoo added B-test Notify bot to start testing and removed B-test Notify bot to start testing labels May 25, 2024
@M-Adoo M-Adoo enabled auto-merge May 25, 2024 09:33
@M-Adoo M-Adoo added this pull request to the merge queue May 25, 2024
Merged via the queue into RibirX:master with commit abd5c6f May 25, 2024
15 checks passed
@M-Adoo M-Adoo deleted the refactor/not-depends-backend-msaa branch May 25, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants