-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/not depends backend msaa #584
Merged
M-Adoo
merged 4 commits into
RibirX:master
from
M-Adoo:refactor/not-depends-backend-msaa
May 25, 2024
Merged
Refactor/not depends backend msaa #584
M-Adoo
merged 4 commits into
RibirX:master
from
M-Adoo:refactor/not-depends-backend-msaa
May 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70218d9
to
4b037ea
Compare
bf4cecc
to
1906f4f
Compare
289a16b
to
c414ec8
Compare
c414ec8
to
082db2c
Compare
082db2c
to
cce8618
Compare
cce8618
to
a54c453
Compare
wjian23
previously approved these changes
May 24, 2024
…er` package This responsibility now lies with the painter backend. The GPU backend no longer relies on MSAA, which is dependent on the graphics API. Instead, it uses the alpha atlas to provide a solution similar to SSAA.
sologeek
previously approved these changes
May 25, 2024
implement a 3x2 sample in shader and not require MSAA and additional texture memory.
…date the image cases
a54c453
to
b2f0961
Compare
wjian23
approved these changes
May 25, 2024
sologeek
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this Pull Request
How to Review/Test this Pull Request
You can review the code commit by commit, and run the example to see the result in the browser.
cargo run-wasm -p counter ## Checklist Before Merging
Please ensure the following are completed before merging:
CHANGELOG.md
file.Breaking
section of theCHANGELOG.md
file.Additional Information
The bot will replace
#pr
inCHANGELOG.md
with your pull request number. If your branch is out of sync, usegit pull --rebase
to update it.If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.