Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat query writer #601

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Feat query writer #601

merged 2 commits into from
Jun 14, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Jun 12, 2024

Purpose of this Pull Request

  1. Implementing a render widget no longer requires the Query trait.
  2. Added support to query a WriteRef from a state writer.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@M-Adoo M-Adoo enabled auto-merge June 12, 2024 09:23
@M-Adoo M-Adoo requested a review from sologeek June 12, 2024 09:23
@github-actions github-actions bot force-pushed the feat-query-writer branch from ad4e8d7 to 4fbadbe Compare June 12, 2024 09:23
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jun 12, 2024
@M-Adoo M-Adoo force-pushed the feat-query-writer branch from 4fbadbe to d98aa6e Compare June 12, 2024 13:13
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jun 12, 2024
@github-actions github-actions bot force-pushed the feat-query-writer branch from d98aa6e to 0b841ef Compare June 12, 2024 13:13
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jun 12, 2024
@M-Adoo M-Adoo force-pushed the feat-query-writer branch from 0b841ef to 43631f8 Compare June 12, 2024 13:28
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Jun 12, 2024
@github-actions github-actions bot force-pushed the feat-query-writer branch from 43631f8 to 121a72a Compare June 12, 2024 13:28
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Jun 12, 2024
@M-Adoo M-Adoo disabled auto-merge June 14, 2024 05:14
@M-Adoo M-Adoo merged commit 270f3a2 into RibirX:master Jun 14, 2024
7 checks passed
@M-Adoo M-Adoo deleted the feat-query-writer branch June 14, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant