Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macros): 🎸 implement same name macro for widget derive Declare #651

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Nov 7, 2024

Purpose of this Pull Request

Add a quick function macro for every widget that derives Declare.

Checklist Before Merging

Please ensure the following are completed before merging:

  • If this is linked to an issue, include the link in your description.
  • If you've made changes to the code or documentation, make sure these are updated in the CHANGELOG.md file.
  • If you've introduced any break changes, briefly describe them in the Breaking section of the CHANGELOG.md file.

Additional Information

The bot will replace #pr in CHANGELOG.md with your pull request number. If your branch is out of sync, use git pull --rebase to update it.

If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.

If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.

@M-Adoo M-Adoo requested a review from wjian23 November 7, 2024 01:50
@github-actions github-actions bot force-pushed the feat/widget-fn-macro branch from 1d2306a to c995ea7 Compare November 7, 2024 01:50
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Nov 7, 2024
@M-Adoo M-Adoo enabled auto-merge November 7, 2024 03:36
@M-Adoo M-Adoo disabled auto-merge November 7, 2024 03:43
@M-Adoo M-Adoo force-pushed the feat/widget-fn-macro branch from c995ea7 to 4524a3f Compare November 7, 2024 04:17
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Nov 7, 2024
@github-actions github-actions bot force-pushed the feat/widget-fn-macro branch from 4524a3f to 4636bd8 Compare November 7, 2024 04:17
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Nov 7, 2024
@M-Adoo M-Adoo force-pushed the feat/widget-fn-macro branch from 4636bd8 to 4d75619 Compare November 7, 2024 04:34
@M-Adoo M-Adoo removed the B-test Notify bot to start testing label Nov 7, 2024
@github-actions github-actions bot force-pushed the feat/widget-fn-macro branch from 4d75619 to 84f5d95 Compare November 7, 2024 04:34
@M-Adoo M-Adoo added the B-test Notify bot to start testing label Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 98.24561% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.55%. Comparing base (4b46cd1) to head (84f5d95).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
core/src/widget_children/compose_child_impl.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
- Coverage   83.51%   82.55%   -0.97%     
==========================================
  Files         196      197       +1     
  Lines       25985    26098     +113     
==========================================
- Hits        21701    21544     -157     
- Misses       4284     4554     +270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@M-Adoo M-Adoo enabled auto-merge November 7, 2024 07:55
@M-Adoo M-Adoo added this pull request to the merge queue Nov 8, 2024
Merged via the queue into RibirX:master with commit ef04673 Nov 8, 2024
8 of 9 checks passed
@M-Adoo M-Adoo deleted the feat/widget-fn-macro branch November 8, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-test Notify bot to start testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants