-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/slider #669
Feat/slider #669
Conversation
6124918
to
cf3e04b
Compare
16d4787
to
0145549
Compare
a0c2e20
to
faf8994
Compare
f5c7da6
to
a05892f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #669 +/- ##
==========================================
+ Coverage 83.93% 84.22% +0.29%
==========================================
Files 200 208 +8
Lines 26350 28272 +1922
==========================================
+ Hits 22116 23812 +1696
- Misses 4234 4460 +226 ☔ View full report in Codecov by Sentry. |
}); | ||
|
||
classes.insert(STOP_INDICATOR_ACTIVE, stop_indicator_class! { | ||
background: Palette::of(BuildCtx::get()).on_primary() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using BuildCtx::get().variant_color()
instead of.
}); | ||
|
||
classes.insert(STOP_INDICATOR_INACTIVE, stop_indicator_class! { | ||
background: Palette::of(BuildCtx::get()).on_secondary_container() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using BuildCtx::get().variant_color_container()
instead of.
…accept pipe value
Purpose of this Pull Request
Please briefly describe what this Pull Request is aiming to achieve.
Checklist Before Merging
Please ensure the following are completed before merging:
CHANGELOG.md
file.Breaking
section of theCHANGELOG.md
file.Additional Information
The bot will replace
#pr
inCHANGELOG.md
with your pull request number. If your branch is out of sync, usegit pull --rebase
to update it.If you're unsure about which branch to submit your Pull Request to, or when it will be released after being merged, please refer to our Release Guide.
If you're working on a widget and need help writing test cases, we have some macros that can assist you. Please refer to the Ribir Dev Helper documentation.