Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ?format=esm query #102

Merged
merged 1 commit into from
Jan 7, 2020
Merged

support ?format=esm query #102

merged 1 commit into from
Jan 7, 2020

Conversation

Rich-Harris
Copy link
Owner

Closes #97. This would allow Packd to generate ES module bundles in some cases (the ones where Browserify isn't involved), if the URL has ?format=esm. Valid formats are esm and umd (the default, meaning this change isn't breaking).

Any thoughts @xtuc / @marcofugaro?

@marcofugaro
Copy link

That sounds perfect!

@Rich-Harris Rich-Harris merged commit f69123f into master Jan 7, 2020
@Rich-Harris Rich-Harris deleted the esm-format branch January 7, 2020 16:36
@marcofugaro
Copy link

Awesome! Now this just needs a line in the Using section of the readme

@Rich-Harris
Copy link
Owner Author

Ah good point! Done f9ba991#diff-04c6e90faac2675aa89e2176d2eec7d8

@Rich-Harris
Copy link
Owner Author

@xtuc what's involved in deploying this to bundle.run btw? (no rush of course, just curious)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support compilation to esm as well?
2 participants