Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose port and use uglify-js #16

Merged
merged 3 commits into from
Jul 23, 2017
Merged

Conversation

xtuc
Copy link
Collaborator

@xtuc xtuc commented Jul 22, 2017

No description provided.

@xtuc xtuc mentioned this pull request Jul 22, 2017
Closed
@xtuc
Copy link
Collaborator Author

xtuc commented Jul 22, 2017

I used uglify-js instead of uglifyjs because I had a deprecate message.

It looks like there is a small diff: https://bundle.run/left-pad@1.1.3 vs https://packd.now.sh/left-pad@1.1.3.

@Rich-Harris
Copy link
Owner

Awesome! It looks like the difference is because minification is failing because of an API change between uglifyjs and uglify-js — I've fixed it.

What's the easiest way for us to keep bundle.run up to date with the latest version? Is there an easy way to automatically deploy changes to the master branch? (Think I'll set that up with packd.now.sh now that I think of it.)

Thanks so much for doing this!

@Rich-Harris Rich-Harris merged commit fdcc860 into Rich-Harris:master Jul 23, 2017
@xtuc
Copy link
Collaborator Author

xtuc commented Jul 23, 2017

Ok, thanks.

We can setup a deployment process in the CI to deploy a new version (from master) on bundle.run. For now i'm going to manually update it.

Edit:
It's online: https://bundle.run/left-pad@1.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants