-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies #65
Conversation
Also closes #4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Rich-Harris, thanks for your PR!
|
||
if ( bundle.imports.length > 0 ) { | ||
if ( result.output.length > 1 ) { | ||
info( `[${pkg.name}] generated multiple chunks, trying Browserify instead` ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which case does Rollup genrate multiple chunks for a lib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't think of any. It's really just there as a fallback — since Rollup now supports code-splitting for apps, it will always emit an array of chunks, and this is just a sanity check before we return the contents of the first chunk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think dynamic import()
might produce multiple chunks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I thought about that, but I don't think it's commonly used on npm?
I'll bump the version number — also, I was thinking of running the code through Prettier, any objections? I've abandoned jQuery style, it's a little dated... |
Thank you, I'll ensure bundle.run is up-to-date and i'm fine with Prettier. |
Cool — tagged 2.7.0. Thanks for taking care of bundle.run! |
This updates Rollup to 1.0, enabling Packd to handle .mjs files (fixes #63). It also replaces uglify-js with Terser, which means it can minify ES2015 packages instead of bailing and serving unminified code.