Support composite Telugu characters #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you Oliver, you are amazing! Really surprised for your commitment and how you could understand the alphabets of the language, their combinations. Kudos to great work! A big salute! Eagerly waiting to see the language working!! |
Richienb
reviewed
Feb 10, 2022
Richienb
changed the title
|
Thanks! |
|
You're welcome. Sorry that I obviously caused some extra code tweaking work for you. |
|
Thank you!! and Kudos to the great work!
best,
Sushumna.
…On Tue, Feb 15, 2022 at 12:11 PM Oliver Tacke ***@***.***> wrote:
You're welcome. Sorry that I obviously caused some extra code tweaking
work for you.
—
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIID3O5JKUQ5UKBKKM66UJLU3HYQFANCNFSM5OAICNRA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
regards,
Sushumnarao T.
#happymoodling
మన పరిసరాలు పచ్చగా ఉంచుదాం! మనం పది కాలాలు పచ్చగా ఉందాం!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged in, the regular expression provided by
charRegex()will contain support for composite Telugu characters.Telugu characters can consist of multiple code points that follow some particular rules and need to be handled separately. The proposed solution includes the amendment to the regular expression and a corresponding test based on programmatically creating all possible Telugu characters (could potentially be put in a separate module). Kudos to "Sushumna" for patiently explaining Telugu script.
Fixes #1