Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unknown props warning in React 15.2.1, ES6'ize, add sheet caching, better regex for matching selectors #16

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

luigiplr
Copy link

@luigiplr luigiplr commented Jul 18, 2016

PR fixes the following warning when used with React15.2.1

https://fb.me/react-unknown-prop
https://fb.me/react-unknown-prop

Other changes include:

  • bringing component up to ES6 spec
  • New method for assigning default uniqe ID's (namespaces)
  • refactoring webpack configuration
  • changes to package.json scripts (see readme)
  • dependency updates
  • prepublish task (babel)
  • add sheet caching to prevent un-needed regex parsing
  • enhance regex to allow for input attribute selectors

@luigiplr luigiplr changed the title Fix: Unknown props warning in most recent react reversion Fix: Unknown props warning in React 15.2.1 Jul 18, 2016
allows matching of "input[type="checkbox"]"
particularly helpful with larger stylesheets.
@luigiplr luigiplr changed the title Fix: Unknown props warning in React 15.2.1 Fix: Unknown props warning in React 15.2.1, ES6'ize, add sheet caching, better regex for matching selectors Jul 19, 2016
@alexchiri
Copy link

I've been noticing these little buggers warnings lately. Would be great to have them go away! :-)

@RickWong
Copy link
Owner

Thanks guys I will merge this later today.

@willbutler
Copy link
Collaborator

@luigiplr I don't think the conflicts are major. Would you mind rebasing your branch onto master so we can get this merged? Thanks!

@github-staff github-staff deleted a comment from mehdi-dev97 May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants