Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix .net8 target while publishing artifacts #4680

Merged
merged 2 commits into from
Jan 10, 2024
Merged

build: fix .net8 target while publishing artifacts #4680

merged 2 commits into from
Jan 10, 2024

Conversation

krzyhan
Copy link
Contributor

@krzyhan krzyhan commented Jan 4, 2024 •
edited
Loading

Seems like there is a bug (typo) and therefore the artifacts are copied into a different place

@krzyhan krzyhan mentioned this pull request Jan 4, 2024
Open
@krzyhan
Copy link
Contributor Author

krzyhan commented Jan 4, 2024

@lahma I also noticed that NSwag.Commands is missing net8.0 target.

Should I added in this PR?

@lahma
Copy link
Collaborator

lahma commented Jan 4, 2024

@lahma I also noticed that NSwag.Commands is missing net8.0 target.

Should I added in this PR?

Hmmm.. probably wouldn't hurt as the csproj has conditional references that aren't even being triggered due to missing net8.0 target framework.

@krzyhan krzyhan requested a review from lahma January 4, 2024 21:23
@krzyhan krzyhan mentioned this pull request Jan 4, 2024
Closed
@dylanvdmerwe dylanvdmerwe mentioned this pull request Jan 5, 2024
Open
@dylanvdmerwe
Copy link

Can we get this released please?

@RicoSuter RicoSuter merged commit b7adb26 into RicoSuter:master Jan 10, 2024
1 check passed
@MehdiElMellali
Copy link

MehdiElMellali commented Jan 10, 2024 •
edited
Loading

How can I obtain this fix? Is it through a new update of the Negut package?

@Saibamen
Copy link
Contributor

@MehdiElMellali: Please update to v14.0.1

@krzyhan krzyhan deleted the feature/v14_fix_build branch January 11, 2024 08:43
@dylanvdmerwe
Copy link

#4699

14.0.1 is not available on npm.

@dennisdevetter
Copy link

Any ETA when fix 14.0.1 will be available for the .NET8 runtime ?

@oliverw
Copy link

oliverw commented Jan 11, 2024

@MehdiElMellali: Please update to v14.0.1

Are we supposed to compile NSwagStudio from source? There are no installers for 14.0.1.

@Insire
Copy link

Insire commented Jan 11, 2024 •
edited
Loading

as dennisdevetter mentioned, in #4699 , the (release/build) pipeline failed. Publishing installers and packages is/was part of that pipeline. Until that passes, there wont be any packages or installers

lahma pushed a commit to lahma/NSwag that referenced this pull request Jun 13, 2024
@krzyhan @lahma
build: fix .net8 target while publishing artifacts (RicoSuter#4680)
a155003 
* build: fix .net8 target while publishing artifacts

* fix(Commands): add net8 target

---------

Co-authored-by: Krzysztof Hankus <khankus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahma lahma lahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@krzyhan @lahma @dylanvdmerwe @MehdiElMellali @Saibamen @dennisdevetter @oliverw @Insire @RicoSuter