Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vulnerability #114

Closed
ShahanaFarooqui opened this issue Apr 7, 2019 · 4 comments
Closed

Remove vulnerability #114

ShahanaFarooqui opened this issue Apr 7, 2019 · 4 comments
Assignees
Labels
blocked vulnerability Issues related to security vulnerabilities

Comments

@ShahanaFarooqui
Copy link
Collaborator

Remove node-sass vulnerability

@ShahanaFarooqui ShahanaFarooqui self-assigned this Apr 7, 2019
@saubyk saubyk added the vulnerability Issues related to security vulnerabilities label Apr 7, 2019
@saubyk saubyk added this to the Release 0.2.17-beta milestone Apr 7, 2019
ShahanaFarooqui added a commit that referenced this issue Apr 14, 2019
Manually removed vulnerability by upgrading 'tar' package from 2.2.1 to 4.4.8 (https://stackoverflow.com/questions/55635378/angular-devkit-build-angular-arbitrary-file-overwrite). angular-devkit and node-sass issues are still open. (angular/angular-cli#14138, sass/node-sass#2625). Will permanently be fixed once above 2 issues are addressed by Angular and node-sass teams.
@ShahanaFarooqui
Copy link
Collaborator Author

Manually removed vulnerability by upgrading 'tar' package from 2.2.1 to 4.4.8 (https://stackoverflow.com/questions/55635378/angular-devkit-build-angular-arbitrary-file-overwrite). angular-devkit and node-sass issues are still open. (angular/angular-cli#14138, sass/node-sass#2625). Will permanently be fixed once above 2 issues are addressed by Angular and node-sass teams.

@ShahanaFarooqui
Copy link
Collaborator Author

Removed manual fix, waiting for official fixes from node-sass and angular teams.

@ShahanaFarooqui
Copy link
Collaborator Author

ShahanaFarooqui commented May 3, 2019

We are still waiting for node-sass and angular-cli to remove these vulnerabilities from their end. Node-sass is using older version of node-gyp which is using tar version 2. Node-sass is taking time to upgrade due to backward compatibility. Angular-cli is using node-sass and also waiting for them to remove the vulnerability. So, both vulnerabilities will be removed when node-sass upgrades node-gyp. We are keeping track of these issues and will fix RTL as soon as angular-cli and node-sass will be fixed.

Initially, we fixed the issue manually but after doing some more research, we were confident that these vulnerabilities will not effect RTL users adversely and decided to remove manual intervention from npm dependencies.

In short, the vulnerability will be removed from node-sass and it is safe to use RTL with this vulnerability.

@saubyk saubyk reopened this May 12, 2019
@ShahanaFarooqui ShahanaFarooqui removed this from the Release 0.3.0-beta milestone May 12, 2019
ShahanaFarooqui added a commit that referenced this issue May 17, 2019
Issue #114 Vulnerability Fix
@ShahanaFarooqui
Copy link
Collaborator Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked vulnerability Issues related to security vulnerabilities
Projects
None yet
Development

No branches or pull requests

2 participants