-
Notifications
You must be signed in to change notification settings - Fork 157
β¨ Split signals
into triggers
and guards
#247
base: development
Are you sure you want to change the base?
Changes from all commits
bca116a
33064bd
c8ae749
67205f2
6419f80
2f8a95b
014c238
faeea55
060dff2
adf3e5b
d50a87d
f5adec0
9ad503a
e3170ed
e8e9527
0e0bcba
6439b51
3d51d81
cd66d38
314eb59
7133e5b
2c76774
0d94374
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,15 +17,15 @@ | |
"sell_trades_when_upwards": true | ||
}, | ||
"weighted_signal_spaces": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
With a set of test results from before & after the It also would be preferred to split up multiple There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok I understand the idea to trace properly each change with a single PR. |
||
"sell_profit_only": true, | ||
"sell_profit_only": false, | ||
"min_weighted_signal_value": 0, | ||
"max_weighted_signal_value": 100, | ||
"min_trend_total_signal_needed_value": 60, | ||
"max_weighted_signal_value": 20, | ||
"min_trend_total_signal_needed_value": 10, | ||
"min_trend_total_signal_needed_candles_lookback_window_value": 1, | ||
"max_trend_total_signal_needed_candles_lookback_window_value": 8, | ||
"min_trend_signal_triggers_needed": 2, | ||
"search_threshold_weighted_signal_values": 22, | ||
"search_threshold_trend_total_signal_needed_candles_lookback_window_value": 1, | ||
"min_trend_signal_triggers_needed": 1, | ||
"search_threshold_weighted_signal_values": 2, | ||
"search_threshold_trend_total_signal_needed_candles_lookback_window_value": 3, | ||
"search_threshold_trend_signal_triggers_needed": 1 | ||
}, | ||
"stoploss_spaces": { | ||
|
@@ -161,13 +161,13 @@ | |
} | ||
}, | ||
"dry_run": true, | ||
"dry_run_wallet": 500, | ||
"dry_run_wallet": 1000, | ||
"max_open_trades": -1, | ||
"stake_currency": "USDT", | ||
"stake_amount": 45, | ||
"stake_amount": 300, | ||
"tradable_balance_ratio": 0.99, | ||
"amount_reserve_percent": 0.05, | ||
"amend_last_stake_amount": false, | ||
"amend_last_stake_amount": true, | ||
"last_stake_amount_min_ratio": 0.5, | ||
"cancel_open_orders_on_exit": false, | ||
"use_sell_signal": true, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can remain until right before we're going to merge since it does allow for easily testing the PR,
but we should undo this when the PR is ready to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you this is only a temporary change