feature: disable multicast dns in native webrtc connection (#520)

RingsNetwork · Jan 15, 2024 · 637788d · 637788d
1 parent 5b84532
commit 637788d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 15 deletions.
diff --git a/crates/node/src/logging.rs b/crates/node/src/logging.rs
@@ -149,20 +149,11 @@ pub mod node {
         let subscriber = Registry::default();
         let level_filter = filter::LevelFilter::from_level(level.into());
 
-        // Filter floating log of mdns
-        let mdns_log_filter = filter::FilterFn::new(|metadata| {
-            !metadata.target().starts_with("webrtc_mdns::conn")
-                || [276, 322]
-                    .iter()
-                    .all(|&line| !metadata.line().unwrap_or_default() == line)
-        });
-
         // Stderr
         let subscriber = subscriber.with(
             fmt::layer()
                 .with_writer(std::io::stderr)
-                .with_filter(level_filter)
-                .with_filter(mdns_log_filter.clone()),
+                .with_filter(level_filter),
         );
 
         // Jaeger
@@ -178,8 +169,7 @@ pub mod node {
                 subscriber.with(Some(
                     tracing_opentelemetry::layer()
                         .with_tracer(jaeger)
-                        .with_filter(level_filter)
-                        .with_filter(mdns_log_filter),
+                        .with_filter(level_filter),
                 ))
             } else {
                 subscriber.with(None)

diff --git a/crates/transport/src/connections/native_webrtc/mod.rs b/crates/transport/src/connections/native_webrtc/mod.rs
@@ -199,10 +199,9 @@ impl TransportInterface for WebrtcTransport {
         if let Some(ref addr) = self.external_address {
             tracing::debug!("setting external ip {:?}", addr);
             setting.set_nat_1to1_ips(vec![addr.to_string()], RTCIceCandidateType::Host);
-            setting.set_ice_multicast_dns_mode(MulticastDnsMode::QueryOnly);
+            setting.set_ice_multicast_dns_mode(MulticastDnsMode::Disabled);
         } else {
-            // mDNS gathering cannot be used with 1:1 NAT IP mapping for host candidate
-            setting.set_ice_multicast_dns_mode(MulticastDnsMode::QueryAndGather);
+            setting.set_ice_multicast_dns_mode(MulticastDnsMode::Disabled);
         }
 
         let webrtc_api = webrtc::api::APIBuilder::new()