Skip to content

Commit

Permalink
fix #127
Browse files Browse the repository at this point in the history
  • Loading branch information
DivadNojnarg committed Apr 26, 2021
1 parent 8878c42 commit c4725c8
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 8 deletions.
3 changes: 2 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ broken `userBox()` in 2.0.0.
- Fix #132: Option to disable the "scroll to top" button.

## Bug fix
- Fix #112: `userBox()` is not working. Introduced in 2.0.0
- Fix #127: `shiny::navlistPanel()` in `dashboardControlbar()` not behaving as expected.
- Fix #112: `userBox()` is not working. Introduced in 2.0.0.


# shinydashboardPlus 2.0.0
Expand Down
2 changes: 1 addition & 1 deletion R/useful-items.R
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,7 @@ loadingState <- function() {
#' @rdname navPills
navPills <- function(..., id = NULL) {
shiny::tags$ul(
class = "nav nav-pills nav-stacked",
class = "nav nav-pills nav-stacked shinydashboardplus-custom",
id = if (!is.null(id)) id,
...
)
Expand Down
3 changes: 2 additions & 1 deletion docs/news/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ articles:
improved-boxes: improved-boxes.html
more-skins: more-skins.html
shinydashboardPlus: shinydashboardPlus.html
last_built: 2021-04-26T10:23Z
last_built: 2021-04-26T10:51Z

2 changes: 1 addition & 1 deletion inst/shinydashboardPlus-2.0.0/js/shinydashboardPlus.js
Original file line number Diff line number Diff line change
Expand Up @@ -1336,7 +1336,7 @@ var navPillsBinding = new Shiny.InputBinding();

$.extend(navPillsBinding, {
find: function(scope) {
return $(scope).find(".nav.nav-pills.nav-stacked");
return $(scope).find(".nav.nav-pills.nav-stacked.shinydashboardplus-custom");
},
// Given the DOM element for the input, return the value
getValue: function(el) {
Expand Down
2 changes: 1 addition & 1 deletion inst/shinydashboardPlus-2.0.0/js/shinydashboardPlus.min.js

Large diffs are not rendered by default.

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion srcjs/shinydashboardPlus-2.0.0/navs.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var navPillsBinding = new Shiny.InputBinding();

$.extend(navPillsBinding, {
find: function(scope) {
return $(scope).find(".nav.nav-pills.nav-stacked");
return $(scope).find(".nav.nav-pills.nav-stacked.shinydashboardplus-custom");
},
// Given the DOM element for the input, return the value
getValue: function(el) {
Expand Down

0 comments on commit c4725c8

Please sign in to comment.