Don't return Google fonts that have a single subset of 'khmer' #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donnapep
force-pushed
the
chore/filter-google-fonts
branch
from
9418b18
to
6966d0e
Compare
|
@stulees @rodrigopavezi Please review. Thx. |
| $httpBackend.flush(); | ||
|
|
||
| expect(googleFontLoader.getGoogleFonts().urls).to.have.lengthOf(1); | ||
| }); |
There was a problem hiding this comment.
@donnapep Why isn't Buda returned since it doesn't have the 'khmer' subset?
There was a problem hiding this comment.
@stulees It's being explicitly filtered out here since Google returns it in their API, but it doesn't return the font when requested - https://fonts.googleapis.com/css?family=Buda.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, upgrade Angular to be inline with our Widgets and to resolve this issue.