Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes on Basis for Design tab (Design Properties) #482

Closed
Tracked by #473
KellyMWhitehead opened this issue Aug 23, 2024 · 3 comments
Closed
Tracked by #473

Changes on Basis for Design tab (Design Properties) #482

KellyMWhitehead opened this issue Aug 23, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@KellyMWhitehead
Copy link
Collaborator

KellyMWhitehead commented Aug 23, 2024

Motivation: Add an optional drop down in design under Bases for Design tab to add DCEs by a planning collection instead of separately for each.

  1. Change the drop downs to use the EventLibrary widget
  2. save and load these to design metadata
  3. Allow user to add remove events using individual dces
  4. Allow user to add remove events based on a planning container (would this lock down user options then?)
@KellyMWhitehead KellyMWhitehead changed the title Add an optional drop down in design under Bases for Design tab to add DCEs by a planning collection instead of separately for each. Changes on Basis for Design tab (Design Properties) Aug 23, 2024
@KellyMWhitehead KellyMWhitehead self-assigned this Aug 23, 2024
@KellyMWhitehead KellyMWhitehead added the enhancement New feature or request label Aug 23, 2024
@KellyMWhitehead KellyMWhitehead added this to the 1.0 - Public Release milestone Aug 26, 2024
@KellyMWhitehead
Copy link
Collaborator Author

@joewheaton @Jdgilby Making updates to the design form to incorporate referencing DCE's via the Planning Containers. Users can either

  1. Select DCE's manually using the same widget that Planning Container uses. Users can specify any number of DCE's and set representation to None, Historic, Contemporary, Predicted.

Image

  1. Under the drop down, users could instead choose an existing Planning Container. This will then populate the table with DCE's based on the Planning Container. The table is then locked down, unless a user selects a different Planning Container or chooses the Manual Selection option again. If a user later makes changes to the Planning Container, those changes are made to the Design (in fact under the hood, I only store the planning container id, unless it is a Manual selection, then I store the individual Events)

Image

  1. This is my real question: Do we need/want the surfaces table in this form (red box)? I add a better label if we want to keep it, otherwise I will disable and hide it for Designs.

Image

Sorry for all the details - I want to be clear as to how currently have this set up. Please let me know if this is on track, or if changes are needed. Thanks!

@KellyMWhitehead
Copy link
Collaborator Author

These changes are included in 0.9.1. Have a play, let me know if further changes are needed.

@joewheaton
Copy link
Contributor

Looks good. We will run with this and if we need to tweak, we can do that post 1.0. Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants