Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Symbology for RIM Project Type #436

Open
11 of 16 tasks
joewheaton opened this issue Jan 7, 2022 · 5 comments · Fixed by #443
Open
11 of 16 tasks

All Symbology for RIM Project Type #436

joewheaton opened this issue Jan 7, 2022 · 5 comments · Fixed by #443
Assignees
Labels
pkg:RIM Riverscape Inundation Mapper symbology Use for new symbology work

Comments

@joewheaton
Copy link
Contributor

joewheaton commented Jan 7, 2022

Specification

Project Type: e.g. [RIM](https://github.com/Riverscapes/RIM)
Layer(s):
All

Description and/or Explanation of Need

Consistent display across all three platforms.


To-Do

  • Start new branch with descriptive name for these changes (e.g. curation_RIM)
  • Make necessary edits to business logic and commit to new branch
  • Author *.qml for QRAVE of layer(s) and test in QRAVE and commit
  • Produce screen shot of each qml layer to provide in commit or later pull request for reviewer (include legend). Also, provide warehouse link to riverscape project you did testing on (use same project(s) for testing ArcRAVE and WebRAVE)
  • Make pull request for just QRAVE changes. Choose appropriate reviewer(s)
  • Author *.lyr for ArcRAVE of layer(s) and test in ArcRAVE and commit
  • Make pull request for just ArcRAVE changes. Choose appropriate reviewer(s)
  • Produce screen shot of each lyr file to provide in commit or later pull request for reviewer (include legend)
  • Author symbology files for WebRAVE and provide link in commit to webRAVE of project it can be tested on
  • Make pull request for just WebRAVE changes. Choose appropriate reviewer(s)
  • Author or Update any project type documentation
  • Update or Add Project Views to Reflect Changes (if necc.)
  • After pull request(s) merged, test in updated qRAVE
  • After pull request(s) merged, test in updated ArcRAVE
  • After pull request(s) merged, test in updated WebRAVE
  • Delete local branch(es) you used for your pull request(s)
@CHafen
Copy link
Contributor

CHafen commented Jan 20, 2022

@Jdgilby here's the curation stuff that needs to get done for RIM

@joewheaton
Copy link
Contributor Author

@CHafen, @jtgilbert and @Jdgilby thanks for this. Just a super minor housekeeping issue. When you do your pull requests, reference the issue they "address" or "fix" e.g. addresses #436 so they show up in this ticket. So when @jtgilbert did:
#438, he could have mentioned this issue there or in the commit: 1b904cd

To show how this shows up above when this is done, I've added those references to both. It is not mission critical, but it makes life easier when you're trying to track down what was done.

@joewheaton joewheaton reopened this Feb 5, 2022
@CHafen CHafen linked a pull request Feb 7, 2022 that will close this issue
@CHafen CHafen reopened this Mar 1, 2022
@CHafen
Copy link
Contributor

CHafen commented Mar 4, 2022

@Jdgilby I updated the Inundation business logic so it will use the symbology that is already in the shared folders (BRAT existing cap, VBET, DEM and hillshade). It seems to work in Q just fine, but the hillshade and dem don't appear to be working in WebRave. When you have a chance would you mind taking a look to see if you can see why it might not be working?

@CHafen
Copy link
Contributor

CHafen commented Mar 30, 2022

@joewheaton this is basically done other than a few issues as described in issue #448 and #451.

@joewheaton
Copy link
Contributor Author

@joewheaton this is basically done other than a few issues as described in issue #448 and #451.

Thanks @CHafen, I'm leaving this one assigned to you but roping in @MattReimer and @jtgilbert so we can finish this finally.

@joewheaton joewheaton added the pkg:RIM Riverscape Inundation Mapper label Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:RIM Riverscape Inundation Mapper symbology Use for new symbology work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants