Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change table to list #9

Merged
merged 1 commit into from
May 31, 2017
Merged

Change table to list #9

merged 1 commit into from
May 31, 2017

Conversation

Ebano
Copy link
Contributor

@Ebano Ebano commented May 31, 2017

Bit of clean-up (#5)

CobraOh
CobraOh reviewed May 31, 2017
View reviewed changes
app/views/tasks/index.html.erb
<td><%= link_to 'Edit', edit_task_path(task) %></td>
<td><%= link_to 'Destroy', task, method: :delete, data: { confirm: 'Are you sure?' } %></td>
</tr>
<li class="<%= task.done ? :done : :todo %>">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

CobraOh
CobraOh approved these changes May 31, 2017
View reviewed changes
Copy link
Contributor

@CobraOh CobraOh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enjoying the 1 liner Ruby code.

@CobraOh CobraOh merged commit 3b80b73 into master May 31, 2017
@CobraOh CobraOh deleted the make-list branch May 31, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CobraOh CobraOh CobraOh approved these changes

@MarMarMet MarMarMet Awaiting requested review from MarMarMet

@eulenfrau eulenfrau Awaiting requested review from eulenfrau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ebano @CobraOh