Add referrer to trial and demo requests #1369
Conversation
| @@ -15,6 +15,7 @@ | |||
| "@algolia/autocomplete-theme-classic": "^1.5.1", | |||
| "@headlessui/react": "^1.4.1", | |||
| "@heroicons/react": "^1.0.4", | |||
| "@reach/router": "^1.3.4", | |||
There was a problem hiding this comment.
This is already a dependency of gatsby. I pulled it in so I can use useLocation in the <Link /> component.
src/components/Link/Link.js
Outdated
| const stringSearchParams = new URLSearchParams(searchParams).toString(); | ||
|
|
||
| if (ctaTo.includes('?')) { | ||
| return `${ctaTo}&${stringSearchParams}`; |
There was a problem hiding this comment.
Is there a better way to do this than conditionally appending & or ??
| @@ -23,7 +23,7 @@ const RequestTrial = ({ data, location }) => { | |||
| /> | |||
|
|
|||
| <div className="min-h-screen bg-white"> | |||
| <SitewideHeader ctaText="Request a Demo" ctaTo="/request-demo/" /> | |||
| <SitewideHeader ctaText="Request a Demo" /> | |||
There was a problem hiding this comment.
This is the default in the <SitewideHeader />
| @@ -111,7 +115,7 @@ | |||
| "test": "cypress run", | |||
| "lint": "eslint src", | |||
| "preview": "yarn run build && netlify deploy --dir public", | |||
| "test:unit": "mocha --require @babel/register src/**/*.test.js", | |||
| "test:unit": "jest", | |||
There was a problem hiding this comment.
I switched all unit tests to jest instead of mocha because I needed to use full DOM rendering (rather than shallow rendering) in the tests of the <Link /> component. Jest has better integrations with JSDOM for doing this. There wasn't many unit tests in the site so it didn't take long.
| @@ -48,6 +73,8 @@ const Link = ({ | |||
| forceOpenInSameTab = false, | |||
| ...rest | |||
| }) => { | |||
| const location = useLocation(); | |||
There was a problem hiding this comment.
Now that this component uses a hook which relies on looking up the location on the window object, we need to provide a window like environment for testing. Hence the switch to jest and JSDOM for the tests of this component. They are probably better tests now anyway, since they run in an environment more like userland.
|
No description provided.