Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourse Graph - Migrating Format to Specification #189

Open
3 tasks
mdroidian opened this issue Dec 8, 2023 · 3 comments
Open
3 tasks

Discourse Graph - Migrating Format to Specification #189

mdroidian opened this issue Dec 8, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@mdroidian
Copy link
Collaborator

mdroidian commented Dec 8, 2023

Listing notes here relating to fully deprecating format in favor of specification

@mdroidian
Copy link
Collaborator Author

mdroidian commented Dec 8, 2023

Fix default node in dgraph specification

It defaults to returning the name of the node. We removed that (in favor of solely node) in all other instances of query builder (blocks, pages, drawer), so I'm guessing it should be removed here as well.

Regardless, it needs to be changed or fixed, because it cannot be targeted in additional conditions
image

@mdroidian
Copy link
Collaborator Author

mdroidian commented Dec 8, 2023

Update relationships to use specification for source / destination

It looks like relationships define what "is a node" rather than use specification to determine if is a someDgraphNode matches.

For example
Based on how is a works in a query builder instance (is a Evidence returns all evidence), I would expect this relationship to only return [[some Evidence]] and not [[EVD]] as defined in the specification for the Discourse Context

image

@mdroidian
Copy link
Collaborator Author

mdroidian commented Dec 8, 2023

Update relationship preview to use specification

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant