-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to pass tag from another action #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional entrypoint
* Add title optional * Update action.yml * Fix title for release * Fix release name * Move title * Test * test * fix entrypoint.sh * test * Cleanup code, Update doc
Roang-zero1
reviewed
Dec 6, 2019
Ye, forgot about removing it. |
* Merge set_release_title and create_release_data as they both deal with the release JSON. * Use empty string for release_title as false may be an allowed value.
* Use empty string as default value. * Re-format function.
* Remove forced update in created_tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2 this PR allows to pass a tag from another action to fully automate the process of creating a tag, updating the release. "Workaround" since it is not possible to trigger a workflow through another workflow/action (push tag with one workflow, listen on event with second workflow is not possible).