shortcut the sub and and

RoaringBitmap · Aug 19, 2022 · ea2ba1e · ea2ba1e
1 parent 95ba91b
commit ea2ba1e
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/src/bitmap/ops.rs b/src/bitmap/ops.rs
@@ -571,7 +571,12 @@ fn try_simple_multi_op_owned<E>(
     let mut iter = bitmaps.into_iter();
     match iter.next().transpose()? {
         Some(mut lhs) => {
-            iter.try_for_each(|rhs| rhs.map(|rhs| op(&mut lhs, rhs)))?;
+            for rhs in iter {
+                if lhs.is_empty() {
+                    return Ok(lhs);
+                }
+                op(&mut lhs, rhs?);
+            }
             Ok(lhs)
         }
         None => Ok(RoaringBitmap::default()),
@@ -586,7 +591,13 @@ fn try_simple_multi_op_ref<'a, E>(
     let mut iter = bitmaps.into_iter();
     match iter.next().transpose()?.cloned() {
         Some(mut lhs) => {
-            iter.try_for_each(|rhs| rhs.map(|rhs| op(&mut lhs, rhs)))?;
+            for rhs in iter {
+                if lhs.is_empty() {
+                    return Ok(lhs);
+                }
+                op(&mut lhs, rhs?);
+            }
+
             Ok(lhs)
         }
         None => Ok(RoaringBitmap::default()),