Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add select #135

Closed
2 of 3 tasks
Tracked by #178
saik0 opened this issue Jan 12, 2022 · 3 comments · Fixed by #170 or #192
Closed
2 of 3 tasks
Tracked by #178

Feature: Add select #135

saik0 opened this issue Jan 12, 2022 · 3 comments · Fixed by #170 or #192

Comments

@saik0
Copy link
Contributor

saik0 commented Jan 12, 2022 •
edited
Loading

Add select​(n) which returns the nth set bit
@saik0 saik0 mentioned this issue Jan 31, 2022
Merged
@bors bors bot closed this as completed in 625f729 Jan 31, 2022
@saik0
Copy link
Contributor Author

saik0 commented Feb 2, 2022

Reopening since there's no impl for RoaringTreemap. Whoops.

@saik0
Copy link
Contributor Author

saik0 commented Feb 2, 2022

Hmph. I dont have access to reopen.

Summoning @Kerollmops

@Kerollmops Kerollmops reopened this Feb 2, 2022
@saik0 saik0 mentioned this issue Feb 5, 2022
Merged
bors bot added a commit that referenced this issue Feb 5, 2022
@bors @saik0
Merge #174
fe24499 
174: Add select impl and tests for RoaringTreemap r=Kerollmops a=saik0

Implements `select` for `RoaringTreemap`

See #135 

Needs benchmarks before #135 can be closed

Co-authored-by: saik0 <github@saik0.net>
@saik0 saik0 mentioned this issue Feb 5, 2022
Open
16 tasks
@saik0
Copy link
Contributor Author

saik0 commented Feb 6, 2022

🚩 Blocked by #129 🚩

@saik0 saik0 mentioned this issue Feb 10, 2022
Merged
@bors bors bot closed this as completed in 49455d4 Feb 10, 2022
@bors bors bot closed this as completed in #192 Feb 10, 2022
not-jan pushed a commit to not-jan/roaring-rs that referenced this issue Aug 31, 2022
@bors @saik0
Merge RoaringBitmap#170
12d93af 
170: Add select r=Kerollmops a=saik0

Closes RoaringBitmap#135 

Co-authored-by: saik0 <github@saik0.net>
Co-authored-by: Joel Pedraza <github@saik0.net>
not-jan pushed a commit to not-jan/roaring-rs that referenced this issue Aug 31, 2022
@bors @saik0
Merge RoaringBitmap#174
099f964 
174: Add select impl and tests for RoaringTreemap r=Kerollmops a=saik0

Implements `select` for `RoaringTreemap`

See RoaringBitmap#135 

Needs benchmarks before RoaringBitmap#135 can be closed

Co-authored-by: saik0 <github@saik0.net>
not-jan pushed a commit to not-jan/roaring-rs that referenced this issue Aug 31, 2022
@bors @saik0
Merge RoaringBitmap#192
b80ac27 
192: Benchmarks using real datasets r=Kerollmops a=saik0

Adds benchmarks using all the real datasets.

 * This benchmark suite has gotten so large that I rarely ever run the entire suite at once. I most often find myself using the regex filters like `cargo bench -- '^(:?rank|select)'` in my build-bench-optimize loop
 * My intention is to backport the benchmark crate to 0.8.1 for perf regression test.
 * It's unfortunate that criterion breaks down dimensions by `function * parameter`. The dimension I really care about is `(function + parameter) * version`
 * Throughput measurements vary wildly, as container types don't have the same performance.
 * Thinking out loud: we can always pipe the csv data into some plotter for our own analysis. The reporting isn't ideal, but this PR will allow us to collect the data.

Closes RoaringBitmap#135  

Co-authored-by: saik0 <github@saik0.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add select saik0/roaring-rs
Benchmarks using real datasets saik0/roaring-rs
2 participants
@saik0 @Kerollmops