Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong operation in Sub impl for Store #118

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

kolstae
Copy link

@kolstae kolstae commented Nov 8, 2021

Change current sub-test to trigger the bug

Fixes #117

Change current sub-test to trigger the bug

Fixes RoaringBitmap#117
@Kerollmops
Copy link
Member

Hey @kolstae,

Thank you for the PR, will test that, merge it and release a new version!

bors try

bors bot added a commit that referenced this pull request Nov 8, 2021
@bors
Copy link
Contributor

bors bot commented Nov 8, 2021

try

Build succeeded:

@Kerollmops
Copy link
Member

Merging you PR @kolstae, will release a new version just after, thank you!

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 9, 2021

Build succeeded:

@bors bors bot merged commit 694cd43 into RoaringBitmap:master Nov 9, 2021
@kolstae kolstae deleted the fix-sub-operation branch November 19, 2021 07:57
not-jan pushed a commit to not-jan/roaring-rs that referenced this pull request Aug 31, 2022
118: Fix wrong operation in `Sub` impl for `Store` r=Kerollmops a=kolstae

Change current sub-test to trigger the bug

Fixes RoaringBitmap#117

Co-authored-by: Espen Amble Kolstad <espen.amble.kolstad@finn.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.8.0 Subtraction of two bitmaps gives wrong bitmap
2 participants