Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serde support #226

Merged
merged 5 commits into from
Sep 1, 2022
Merged

Add serde support #226

merged 5 commits into from
Sep 1, 2022

Conversation

irevoire
Copy link
Contributor

Add support for serde to make our serialize function easier to use.

Kerollmops
Kerollmops requested changes Aug 31, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add tests that serialize, deserialize and check equality, please?

Kerollmops
Kerollmops approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, LGTM!
bors merge

bors bot added a commit that referenced this pull request Aug 31, 2022
@bors @irevoire
Merge #226
1c6ab7b 
226: Add serde support r=Kerollmops a=irevoire

Add support for serde to make our serialize function easier to use.

Co-authored-by: Irevoire <tamo@meilisearch.com>
Co-authored-by: Tamo <tamo@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Aug 31, 2022

Build failed:

@Kerollmops
Copy link
Member

Kerollmops commented Aug 31, 2022 •
edited
Loading

What the heck: operation was canceled....
bors merge

bors bot added a commit that referenced this pull request Aug 31, 2022
@bors @irevoire
Merge #226
28583d5 
226: Add serde support r=Kerollmops a=irevoire

Add support for serde to make our serialize function easier to use.

Co-authored-by: Irevoire <tamo@meilisearch.com>
Co-authored-by: Tamo <tamo@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Aug 31, 2022

Build failed:

@Kerollmops
Copy link
Member

bors merge

bors bot added a commit that referenced this pull request Aug 31, 2022
@bors @irevoire
Merge #226
c35038c 
226: Add serde support r=Kerollmops a=irevoire

Add support for serde to make our serialize function easier to use.

Co-authored-by: Irevoire <tamo@meilisearch.com>
Co-authored-by: Tamo <tamo@meilisearch.com>
@bors
Copy link
Contributor

bors bot commented Aug 31, 2022

Build failed:

@Kerollmops
Copy link
Member

Now that we fixed the bug on main, we can try again!
bors merge

@bors
Copy link
Contributor

bors bot commented Sep 1, 2022

Build succeeded:

@bors bors bot merged commit 28db3cb into RoaringBitmap:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kerollmops Kerollmops Kerollmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irevoire @Kerollmops