contains_range / range_cardinality functions #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
requested changes
Aug 30, 2022
There was a problem hiding this comment.
Hey, thank you very much for that, it looks good to me. But would it be possible to add a quickcheck test that:
- One that creates a RoaringBitmap
/Treemapwith a random range, adds more numbers into it (in the front and the back of that range) and check that the original range it contained in it. - One that does the same but we remove some random numbers from inside this range and check that the range is not contained.
|
Note that I just renamed the master branch to main, you should be careful. |
|
Good call, found a place where I had an off-by-one in the range_cardinality function. |
Kerollmops
approved these changes
Aug 31, 2022
|
Build succeeded: |
not-jan
pushed a commit
to not-jan/roaring-rs
that referenced
this pull request
Aug 31, 2022
237: contains_range / range_cardinality functions r=Kerollmops a=Dr-Emann Fixes RoaringBitmap#235 Co-authored-by: Zachary Dremann <dremann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235