implement range based iteration #297
Conversation
There was a problem hiding this comment.
Thank you for this PR @Dr-Emann,
I see that this PR is mostly the same as #298. Can you rebase on main once #299 is merged, please?
However, you propose interesting open questions that I will try to answer here.
The equivalent to
.iter_rangeforBTreeSetis called.range()(and so does #290). Is that a better name:.range/.iter_range? We also need an owning version,into_rangevsinto_iter_range?
I indeed prefer that we use the range naming instead of the iter_range. This way, as you propose, we will be closer to the standard naming. I also think that, at some point, we will want to support extracting ranges but we will probably name this method extract_range.
.rangeonBTreeSetpanics onstart > end. (orstart == endwhen both are excluded). Should we?
Yes, I think a range with a start > end is not expected and most likely an error. We should panic. Same for the start == end case.
|
Hmm, the current utility to to an inclusive range can't currently differentiate |
Can we do it by hand then? If we cannot then, I think, it's better to just accept them as we don't want to panic for valid empty ranges. |
Dr-Emann
force-pushed
the
push-yyvkswtzunrm
branch
from
03682b5 to
d6ad8c4
Compare
|
@Kerollmops Looks like another dependency update broke the MSRV. |
Dr-Emann
force-pushed
the
push-yyvkswtzunrm
branch
from
d6ad8c4 to
8cf9bda
Compare
Implement `bitmap.iter_range()` and `bitmap.into_iter_range()`, based on `advance_to()` and `advance_back_to()`. Co-authored-by: Matthew Herzl <matthew@herzl.email>
Dr-Emann
force-pushed
the
push-yyvkswtzunrm
branch
from
8cf9bda to
50eda41
Compare
| /// Convert a `RangeBounds<u32>` object to `RangeInclusive<u32>`, | ||
| pub fn convert_range_to_inclusive<R>(range: R) -> Option<RangeInclusive<u32>> | ||
| pub fn convert_range_to_inclusive<R>(range: R) -> Result<RangeInclusive<u32>, ConvertRangeError> |
There was a problem hiding this comment.
Indeed the code is not pretty but it is very useful, thank you 😊
Implement
bitmap.iter_range()andbitmap.into_iter_range(), based onadvance_to()andadvance_back_to(). Closes #290.Open questions:
The equivalent toUsing the names.iter_rangeforBTreeSetis called.range()(and so does Add range-based iteration #290). Is that a better name:.range/.iter_range? We also need an owning version,into_rangevsinto_iter_range?range/into_range..rangeonBTreeSetpanics on start > end. (or start == end when both are excluded). Should we?