Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for serialization bug #62

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Bug fix for serialization bug #62

merged 3 commits into from
Sep 10, 2020

Conversation

lemire
Copy link
Member

@lemire lemire commented Sep 9, 2020

See #61

@Kerollmops
Copy link
Member

Kerollmops commented Sep 9, 2020

The CI complains about my commit!

If you can just cargo fmt it could make the CI to pass :)

EDIT: I'm late, sorry!

@lemire
Copy link
Member Author

lemire commented Sep 9, 2020

Ok. Did so.

@Nemo157
Copy link
Collaborator

Nemo157 commented Sep 10, 2020

Nice, thanks for the quick debugging. I should probably make sure there are boundary tests everywhere...

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 10, 2020

Build succeeded:

@bors bors bot merged commit 5bc2b7c into RoaringBitmap:master Sep 10, 2020
@Kerollmops
Copy link
Member

Hey @Nemo157 do you plan to make a new release soon, or do you want to add more tests first, like you said?

@Nemo157
Copy link
Collaborator

Nemo157 commented Sep 10, 2020

I'll publish a new version when I'm home tonight, we'll see if I get round to adding tests beforehand or not 😁

@Nemo157
Copy link
Collaborator

Nemo157 commented Sep 10, 2020

🎉 0.6.1 published

not-jan pushed a commit to not-jan/roaring-rs that referenced this pull request Aug 31, 2022
62: Bug fix for serialization bug r=Nemo157 a=lemire

See RoaringBitmap#61

Co-authored-by: Kerollmops <clement@meilisearch.com>
Co-authored-by: Daniel Lemire <lemire@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants