Non panicking push method #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
better-push-method
branch
from
e13c4cb
to
0324b7b
Compare
Kerollmops
added
the
breaking
|
Thank you very much 😺 bors try |
tryBuild failed: |
MarinPostma
force-pushed
the
better-push-method
branch
from
0324b7b
to
b179d25
Compare
|
sorry, forgot to run fmt. fixed now :) |
tryBuild failed: |
Kerollmops
requested changes
Apr 29, 2021
|
👊 |
MarinPostma
force-pushed
the
better-push-method
branch
3 times, most recently
from
fcac350
to
0fa6be0
Compare
MarinPostma
force-pushed
the
better-push-method
branch
4 times, most recently
from
d2085ac
to
1d7088e
Compare
optimize push and fix correctness min returns option
MarinPostma
force-pushed
the
better-push-method
branch
from
1d7088e
to
d3ba299
Compare
Kerollmops
approved these changes
Apr 29, 2021
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Oct 21, 2021
106: Modify the from_sorted_iter and append methods to return a Result r=Kerollmops a=Kerollmops This PR fixes #103, which means that the `from_sorted_iter` and `append` methods of the `RoaringBit/Treemap` types now return a `Result`. The `Err` value corresponds to the number of values that we appended to the set until we found an erroneous value, it eases debugging. These two methods were containing bugs in the sense that they were silently discarding invalid values instead of panicking, this bug was introduced by #99 which introduced a non-panicking push method. A possible improvement could be to introduce a new error type, something like a `NonSortedIntegers` struct with a `stopped_at`/`valid_until` method that returns the `u64` we currently return as the `Err`. `@MarinPostma` could you please take a look at this PR? If you got the time? Co-authored-by: Kerollmops <clement@meilisearch.com> Co-authored-by: Clément Renault <renault.cle@gmail.com>
not-jan
pushed a commit
to not-jan/roaring-rs
that referenced
this pull request
Aug 31, 2022
99: Non panicking push method r=Kerollmops a=MarinPostma Changes the `push` method to make it not panic when inserting a value that is not greater than the previous. Also make some optimizations that make the push method roughly 20% faster than before. Co-authored-by: Clément Renault <clement@meilisearch.com>
not-jan
pushed a commit
to not-jan/roaring-rs
that referenced
this pull request
Aug 31, 2022
106: Modify the from_sorted_iter and append methods to return a Result r=Kerollmops a=Kerollmops This PR fixes RoaringBitmap#103, which means that the `from_sorted_iter` and `append` methods of the `RoaringBit/Treemap` types now return a `Result`. The `Err` value corresponds to the number of values that we appended to the set until we found an erroneous value, it eases debugging. These two methods were containing bugs in the sense that they were silently discarding invalid values instead of panicking, this bug was introduced by RoaringBitmap#99 which introduced a non-panicking push method. A possible improvement could be to introduce a new error type, something like a `NonSortedIntegers` struct with a `stopped_at`/`valid_until` method that returns the `u64` we currently return as the `Err`. `@MarinPostma` could you please take a look at this PR? If you got the time? Co-authored-by: Kerollmops <clement@meilisearch.com> Co-authored-by: Clément Renault <renault.cle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
pushmethod to make it not panic when inserting a value that is not greater than the previous. Also make some optimizations that make the push method roughly 20% faster than before.