Skip to content

Commit

Permalink
#767: Remove unecassary array_values calls
Browse files Browse the repository at this point in the history
Infection detected that these were not needed
  • Loading branch information
bdsl committed May 19, 2024
1 parent 56cf628 commit 7007cd1
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions src/DetectChanges/BCBreak/EnumBased/CasesChanged.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,9 @@ public function __invoke(ReflectionClass $fromEnum, ReflectionClass $toEnum): Ch
if (! $fromEnum instanceof ReflectionEnum) {
return Changes::empty();
}

if (! $toEnum instanceof ReflectionEnum) {
return Changes::empty();
}

$fromEnumName = $fromEnum->getName();

$addedCases = array_filter(
Expand All @@ -40,6 +38,7 @@ static function (ReflectionEnumCase $case) use ($fromEnum): bool {
},
);


$removedCases = array_filter(
$fromEnum->getCases(),
static function (ReflectionEnumCase $case) use ($toEnum): bool {
Expand All @@ -51,23 +50,23 @@ static function (ReflectionEnumCase $case) use ($toEnum): bool {
},
);

$caseRemovedChanges = array_values(array_map(
$caseRemovedChanges = array_map(
static function (ReflectionEnumCase $case) use ($fromEnumName): Change {
$caseName = $case->getName();

return Change::removed('Case ' . $fromEnumName . '::' . $caseName . ' was removed');
},
$removedCases,
));
);

$caseAddedChanges = array_values(array_map(
$caseAddedChanges = array_map(
static function (ReflectionEnumCase $case) use ($fromEnumName): Change {
$caseName = $case->getName();

return Change::added('Case ' . $fromEnumName . '::' . $caseName . ' was added');
},
$addedCases,
));
);

return Changes::fromList(...$caseRemovedChanges, ...$caseAddedChanges);
}
Expand Down

0 comments on commit 7007cd1

Please sign in to comment.