Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release 8.2.1 into 8.3.x #725

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Release Notes for 8.2.1

8.2.x bugfix release (patch)

8.2.1

  • Total issues resolved: 1
  • Total pull requests resolved: 1
  • Total contributors: 2

bug

Because the configuration for final and non-final classes is almost mirrored, this
is a code duplication problem: the config is large and complex, and these things
kinda happen.

Fixes #723.

Ref: #723 (comment)

Quoting:

> So, I tried it on `vimeo/psalm` with the patch you were referring to:
>
> ```shell
> ../../roave/BackwardCompatibilityCheck/bin/roave-backward-compatibility-check --from=origin/master --to=origin/pr/8961
> <SNIP>
> [BC] CHANGED: The number of required arguments for Psalm\Plugin\EventHandler\Event\StringInterpreterEvent#__construct() increased from 1 to 2
> [BC] CHANGED: The number of required arguments for Psalm\Plugin\EventHandler\Event\BeforeAddIssueEvent#__construct() increased from 2 to 3
> 2 backwards-incompatible changes detected
> ```
>
> I applied a config change:
>
> ```diff
> diff --git a/bin/roave-backward-compatibility-check.php b/bin/roave-backward-compatibility-check.php
> index 2edcf53..c261d6a 100644
> --- a/bin/roave-backward-compatibility-check.php
> +++ b/bin/roave-backward-compatibility-check.php
> @@ -208,7 +208,7 @@ use function file_exists;
>                                  )),
>                              )),
>                              new ClassBased\SkipClassBasedErrors(new ClassBased\MethodChanged(
> -                                new MethodBased\SkipMethodBasedErrors(new MethodBased\OnlyPublicMethodChanged(
> +                                new MethodBased\SkipMethodBasedErrors(new MethodBased\OnlyPublicMethodChanged(new MethodBased\ExcludeInternalMethod(
>                                      new MethodBased\MultipleChecksOnAMethod(
>                                          new MethodBased\SkipMethodBasedErrors(new MethodBased\MethodBecameFinal()),
>                                          new MethodBased\SkipMethodBasedErrors(new MethodBased\MethodConcretenessChanged()),
> @@ -226,7 +226,7 @@ use function file_exists;
>                                              ),
>                                          )),
>                                      ),
> -                                )),
> +                                ))),
>                              )),
>                          ),
>                      )),
> ```
>
> ```shell
> ../../roave/BackwardCompatibilityCheck/bin/roave-backward-compatibility-check --from=origin/master --to=origin/pr/8961
> <SNIP>
> No backwards-incompatible changes detected
> ```
…-issues-also-on-final-classes

Fix #723 by ignoring BC issues on `@internal` methods of `final` classes
@Ocramius Ocramius self-assigned this Dec 21, 2022
@Ocramius Ocramius added the bug label Dec 21, 2022
@Ocramius Ocramius added this to the 8.3.0 milestone Dec 21, 2022
@Ocramius Ocramius merged commit 6c001e1 into 8.3.x Dec 21, 2022
@Ocramius Ocramius deleted the 8.2.x-merge-up-into-8.3.x_9bdR2TMX branch December 21, 2022 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant