Upgrade to PHPUnit v10 #741
Conversation
Some people - like me - have a tweaked/opinionated global Git configuration that forces GPG signatures everywhere, which basically breaks the tests. This standardises the expected configuration for tests, preventing unexpected breakages. Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
PHPUnit 10.x only accepts static data providers, so... Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
|
Replaces #736 |
More info: sebastianbergmann/phpunit#5063 Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
lcobucci
force-pushed
the
upgrade-to-phpunit10
branch
from
20cd2c1
to
d72bef7
Compare
|
Argh, this is possibly blocked by laminas/laminas-ci-matrix-action#189 and laminas/laminas-continuous-integration-action#130 |
Fun! We can "hide" the SEGFAULTs by temporarily relying on Trade-offs, eh!? |
|
Can't we add it as extension to be installed for this package (at least until that addressed on the upstream)? Alternatively we can also use a pre-install script to run arbitrary commands as root: https://github.com/laminas/laminas-continuous-integration-action/blob/1.33.x/entrypoint.sh#L162 That might help to only install a coverage driver for specific jobs and allow moving this forward. |
|
I really just need to do the upstream releasing/fixing: however you put the problem, the blocker is me and my constantly clogged schedule :S |
|
I'd be fine with using |
I'll send a different PR to tackle this, I've the changes in my local history 👍 |
Given the plans for laminas-continuous-integration-action v2 is to always ship PCOV, we can simply enable it here to allow us to detach the two processes. Signed-off-by: Luís Cobucci <lcobucci@gmail.com>
Scratch that, we can already enable PCOV here and solve the issue. I've pushed an extra commit and rebased the baseline PR to verify that CI works for both. @Ocramius @asgrim please approve the workflow run (whenever) on both PRs to make sure things are fine 👍 |
|
Silly me... I've overlooked the generated command for infection on the matrix 🤦 Well, that would never work 🤣 |
|
All the things I can think of are horrendous... let's release CI-action v2 😆 |
|
Yeah, and |
|
@lcobucci doing some paid work, then picking up OCI-CatalogService again |
|
@Ocramius should we close this or bump to v11? 😅 |
|
If it works, we can merge here, although no idea if it does :P My OSS efforts have been almost zero this year, sorry. |
Fix #740
This makes the test suite compatible with the latest PHPUnit version and upgrades everything to it, which removes the SEGFAULTs we were having previously.
(the first commit is from #737, a rebase to sync is more than enough to remove it from the last merged branch)