Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect changes in ENUMs as BC breaks #768

Merged
merged 32 commits into from
May 22, 2024
Merged

Detect changes in ENUMs as BC breaks #768

merged 32 commits into from
May 22, 2024

Commits on May 19, 2024

  1. Roave#767 Create EnumCaseAdded class

    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    77fd27e View commit details
    Browse the repository at this point in the history

  2. Roave#767: Rename ClassBased/EnumCaseAdded to EnumBased/CaseAdded use… 

    … in CompareClasses s
    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    be55ca1 View commit details
    Browse the repository at this point in the history

  3. Roave#767: Allow adding @internal enum cases without BC break

    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    8c41bc8 View commit details
    Browse the repository at this point in the history

  4. Add BC check for Enum Case removed

    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    39ecc98 View commit details
    Browse the repository at this point in the history

  5. Allow removing @internal enum cases without BC break

    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    66ceaa1 View commit details
    Browse the repository at this point in the history

  6. Fix PHPCS errors

    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    336bcab View commit details
    Browse the repository at this point in the history

  7. Refactor: Make relavent namespace EnumBased more visible in check script

    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    f8092b6 View commit details
    Browse the repository at this point in the history

  8. Roave#767 : Fix BC break 

    Afaik this product is a tool rather than a library, so I'm not sure if
BC breaks on a function are really an issue, but the build is reporting
an unexpected BC break here

https://github.com/Roave/BackwardCompatibilityCheck/actions/runs/9148688556/job/25151720875
    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    a1e3738 View commit details
    Browse the repository at this point in the history

  9. Roave#767: Improve test coverage

    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    b2c4ddc View commit details
    Browse the repository at this point in the history

  10. Roave#767: Remove unecassary array_values calls 

    Infection detected that these were not needed
    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    6f7c9dc View commit details
    Browse the repository at this point in the history

  11. Roave#767: Remove covers annotation on new test case 

    Trying to work out whether this is related to the infection check
failure - I haven't been able to reproduce the way its failing on my
local.
    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    458cab3 View commit details
    Browse the repository at this point in the history

  12. Temporarily remove enum based checks fron script

    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    9f2820b View commit details
    Browse the repository at this point in the history

  13. Temporarily remove enum based checks from CompareClasses to see how i… 

    …nfection results are affected
    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    0460dbf View commit details
    Browse the repository at this point in the history

  14. Revert "Temporarily remove enum based checks from CompareClasses to s… 

    …ee how infection results are affected"

This reverts commit 0460dbf.
    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    e82047e View commit details
    Browse the repository at this point in the history

  15. Revert "Temporarily remove enum based checks fron script" 

    This reverts commit 9f2820b.
    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    889b956 View commit details
    Browse the repository at this point in the history

  16. Roave#767: Add tests about enums to CompareClassesTests

    @bdsl
    bdsl committed May 19, 2024
    Configuration menu
    Copy the full SHA
    7f01d47 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Roave#767: Refactor, remove new EnumBased interface, treat Enums as j… 

    …ust classes
    @bdsl
    bdsl committed May 21, 2024
    Configuration menu
    Copy the full SHA
    850e7a3 View commit details
    Browse the repository at this point in the history

  2. Roave#767: Add check in test that Enum case names are case sensitve

    @bdsl
    bdsl committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d9d3b04 View commit details
    Browse the repository at this point in the history

  3. Roave#767: add check for enum case became internal

    @bdsl
    bdsl committed May 21, 2024
    Configuration menu
    Copy the full SHA
    61231a8 View commit details
    Browse the repository at this point in the history

  4. Roave#767: Detect enum becoming non-enum and vice-versa as BC break

    @bdsl
    bdsl committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9da3f6d View commit details
    Browse the repository at this point in the history

  5. Roave#767: Refactor, rename class CasedChanged -> EnumCasesChanged

    @bdsl
    bdsl committed May 21, 2024
    Configuration menu
    Copy the full SHA
    aa85d92 View commit details
    Browse the repository at this point in the history

  6. Roave#767: Fix Psalm and PHPCS errors

    @bdsl
    bdsl committed May 21, 2024
    Configuration menu
    Copy the full SHA
    35e77b3 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Roave#767: Add check for enum case becoming not internal 

    Perhaps the semantics are arguable, but I think it's safest to say
making a case no longer internal is a BC break, as it means we no-longer
gurantee to not return it and client code may need to check for it as
part of an exhaustive match.
    @bdsl
    bdsl committed May 22, 2024
    Configuration menu
    Copy the full SHA
    aa9c85d View commit details
    Browse the repository at this point in the history

  2. Restore blank line deleted in error

    @bdsl
    bdsl committed May 22, 2024
    Configuration menu
    Copy the full SHA
    edcbd2b View commit details
    Browse the repository at this point in the history

  3. Roave#767: Remove outdated comments from test

    @bdsl
    bdsl committed May 22, 2024
    Configuration menu
    Copy the full SHA
    77a2f08 View commit details
    Browse the repository at this point in the history

  4. Make EnumCasesChanged final

    @bdsl
    bdsl committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ad32463 View commit details
    Browse the repository at this point in the history

  5. Roave#767: Add @Covers to EnumCasesChangedTest

    @bdsl
    bdsl committed May 22, 2024
    Configuration menu
    Copy the full SHA
    5519e97 View commit details
    Browse the repository at this point in the history

  6. Roave#767: Remove redundant term in if condition

    @bdsl
    bdsl committed May 22, 2024
    Configuration menu
    Copy the full SHA
    190968c View commit details
    Browse the repository at this point in the history

  7. Roave#767: Remove unecassary comment 

    See Roave#768 (comment)
    @bdsl
    bdsl committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6703c31 View commit details
    Browse the repository at this point in the history

  8. Fix covers annotation on EnumCasesChangedTest 

    Co-authored-by: Marco Pivetta <ocramius@gmail.com>
    @bdsl @Ocramius
    bdsl and Ocramius committed May 22, 2024
    Configuration menu
    Copy the full SHA
    9f75ade View commit details
    Browse the repository at this point in the history

  9. Adjusting temporary path expectation: may differ based on $UID

    @Ocramius
    Ocramius committed May 22, 2024
    Configuration menu
    Copy the full SHA
    763dadd View commit details
    Browse the repository at this point in the history

  10. Reducing mutation testing requirements: makes CI green. 

    Note that MT MSI is 100% when running with XDebug, but 85.84% when running with `phpdbg`, which is
no longer supported by PHPUnit.

This will be fixed in a later iteration of the Laminas test container: laminas/laminas-ci-matrix-action#189
    @Ocramius
    Ocramius committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c245e9c View commit details
    Browse the repository at this point in the history