Added support for Doctrine\Cache 1.7 with deleteMultiple #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Sep 13, 2017
src/Exception/CacheException.php
Outdated
| @@ -8,26 +8,11 @@ | |||
|
|
|||
| final class CacheException extends \RuntimeException implements PsrCacheException | |||
| { | |||
| public static function fromNonClearableCache(DoctrineCache $cache) : self | |||
| public static function fromNonMultiOperationCache(DoctrineCache $cache) : self | |||
There was a problem hiding this comment.
Minor BC break: requires UPGRADE.md notes or revert + deprecation
There was a problem hiding this comment.
fromNonClearableCache shouldn't have gone, oops. Added that back in :)
src/Exception/CacheException.php
Outdated
| )); | ||
| } | ||
|
|
||
| public static function fromNonMultiGetCache(DoctrineCache $cache) : self |
There was a problem hiding this comment.
Minor BC break: requires UPGRADE.md notes or revert + deprecation
| )); | ||
| } | ||
|
|
||
| public static function fromNonMultiPutCache(DoctrineCache $cache) : self |
There was a problem hiding this comment.
Minor BC break: requires UPGRADE.md notes or revert + deprecation
| use Doctrine\Common\Cache\ClearableCache; | ||
| use Doctrine\Common\Cache\MultiGetCache; | ||
|
|
||
| interface NotMultiPuttableCache extends Cache, ClearableCache, MultiGetCache |
There was a problem hiding this comment.
Minor BC break: requires UPGRADE.md notes or revert + deprecation
|
All other BC breaks now documented in upgrade notes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2