Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated dependencies and widen compatibility to include PHP 7.4 #33

Merged
merged 3 commits into from
Oct 23, 2019
Merged

Updated dependencies and widen compatibility to include PHP 7.4 #33

merged 3 commits into from
Oct 23, 2019

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Oct 23, 2019

Fixes #32

@asgrim
Copy link
Member Author

asgrim commented Oct 23, 2019

Hm, not sure why build is failing, maybe 7.4 not available on Travis yet...

$ phpenv global 7.4 2>/dev/null
7.4 is not pre-installed; installing
Downloading archive: https://storage.googleapis.com/travis-ci-language-archives/php/binaries/ubuntu/16.04/x86_64/php-7.4.tar.bz2
0.12s$ curl -s -o archive.tar.bz2 $archive_url && tar xjf archive.tar.bz2 --directory /
bzip2: (stdin) is not a bzip2 file.
tar: Child returned status 2
tar: Error is not recoverable: exiting now
0.00s0.02s$ phpenv global 7.4
rbenv: version `7.4' not installed
The command "phpenv global 7.4" failed and exited with 1 during .

@mimmi20
Copy link
Contributor

mimmi20 commented Oct 23, 2019 •
edited
Loading

Its 7.4snapshot, because 7.4 is not stable yet.

@asgrim
Copy link
Member Author

asgrim commented Oct 23, 2019

@mimmi20 thank you for the pointer, that seems to have worked! 👍

@asgrim asgrim requested a review from Ocramius October 23, 2019 15:52
Ocramius
Ocramius approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ocramius Ocramius self-assigned this Oct 23, 2019
@Ocramius Ocramius added this to the 2.3.0 milestone Oct 23, 2019
@Ocramius Ocramius merged commit 1655991 into master Oct 23, 2019
@Ocramius Ocramius deleted the adds-php74-support branch October 23, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

7.4 Support
3 participants
@asgrim @mimmi20 @Ocramius