Reduce get next question queries #12
Conversation
| self.user.set_password(self.PASSWORD) | ||
| self.user.save() | ||
|
|
||
| def _assign_question_to_user(self, user, question): |
There was a problem hiding this comment.
This name _assign_question_to_user is misleading to me, because it sounds like the question is getting assigned to the user. What is really happening is that the question is getting associated with a tag, and the user is selecting that tag. I don't know what a better name would be, maybe something generic like _associate_tags().
There was a problem hiding this comment.
Hmm right, although what the method really accomplishes is linking a question to a user via Tags, which are basically relationships between questions and users with some metadata, correct?
What about a name like _associate_question_with_user?
There was a problem hiding this comment.
or maybe my idea of what Tags are is a bit off 😕
| self.assertIsInstance(next_question, NextQuestion) | ||
| self.assertIsNone(next_question.question) | ||
|
|
||
| @override_settings(DEBUG=True) |
There was a problem hiding this comment.
What effect does DEBUG=True have on the test?
There was a problem hiding this comment.
Allows you to count queries via - django.db.connections.queries
| question = models.Question.objects.create( | ||
| question='fakebar', | ||
| ) | ||
| self._assign_question_to_user(self.user, question) |
There was a problem hiding this comment.
It would be interesting here to have:
a. one question with no tags
b. one question with a tag by the user, but with no associated UserTag
and then assert that get_user_questions() only returns a count of 8 questions.
There was a problem hiding this comment.
c. one question with a tag by the user, with an associated UserTag with enabled=False
There was a problem hiding this comment.
Definitely, these were just the first two tests I came up with to explore the _get_next_question method. Appreciate you laying out some additional tests for me.
No description provided.