Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script fails with 2 part domain suffixes. #1

Open
eternelpanic opened this issue May 28, 2018 · 3 comments
Open

Script fails with 2 part domain suffixes. #1

eternelpanic opened this issue May 28, 2018 · 3 comments
Assignees
Labels

Comments

@eternelpanic
Copy link

If you use this script for say ".com.au" based domains, the domain parsing in lines 204-220 of Get-NewLetsEncryptCertificate.ps1 and similarly in Register-LetsEncryptCertificateRequest.ps1 fails.
For example: hostname.example.com.au is broken into:
Hostname: hostname.example
FQDN: hostname.example.com.au
DnsZoneName: com.au

This prevents any certificates from being generated.

A basic patch is included, however Im certain this isnt the best approach to fix the issue, just a quick fix that works for me.

DomainSuffixFix.zip

@RobBiddle
Copy link
Owner

Thanks! I'll try to get a fix in place tomorrow.

@RobBiddle RobBiddle self-assigned this Jun 8, 2018
@RobBiddle RobBiddle added the bug label Jun 8, 2018
RobBiddle added a commit that referenced this issue Jun 8, 2018
RobBiddle added a commit that referenced this issue Jun 8, 2018
@RobBiddle
Copy link
Owner

RobBiddle commented Jun 8, 2018

I think I may have fixed it, but I haven't tested it yet.
If you have time @eternelpanic , give the #1 branch a try: https://github.com/RobBiddle/ACMESharpRoute53Automation/tree/Issue1

@eternelpanic
Copy link
Author

Unfortunatley that doesnt work. The DnsZoneName on line 208 and dnshost on 213 ends up incorrect...

The cert we are trying to generate is .online..com.au

I'll look more through it when I get further time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants